feat: integrate ostracon #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 22, 2021 10:16
Codecov Report
@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage ? 53.16%
=======================================
Files ? 642
Lines ? 47460
Branches ? 0
=======================================
Hits ? 25230
Misses ? 19366
Partials ? 2864 |
egonspace
commented
Sep 7, 2021
| @@ -61,7 +61,7 @@ func StatusCommand() *cobra.Command { | |||
| ValidatorInfo: validatorInfo{ | |||
| Address: status.ValidatorInfo.Address, | |||
| PubKey: pk, | |||
| VotingPower: status.ValidatorInfo.VotingPower, | |||
| VotingPower: status.ValidatorInfo.StakingPower, | |||
There was a problem hiding this comment.
ValidatorInfo.VotingPower is changed to ValidatorInfo.StakingPower by Finschia/ostracon@50b4e78#diff-18b278f1fcf823eee4511186b774e4d281c1274b2505685d59aa85f001c3e766
iproudhon
approved these changes
Sep 8, 2021
3 tasks
iproudhon
pushed a commit
that referenced
this pull request
Sep 10, 2021
* fix: treat addresses as strings * fix: compile errors, test failures * fix: works-1 * feat: integrate ostracon * fix: bump up ostracon * fix: lint error * fix: bump up ostracon * fix: self review * fix: modify changelog * fix: disable arm building * fix: bls build failure on arm * fix: bls build failure on arm * fix: bls build failure on arm
iproudhon
added a commit
that referenced
this pull request
Sep 10, 2021
…320) * perf: internal objects optimization (BaseAccount, Balance & Supply) * replaced cdc.(Un)MarshalInterface() with protobuf (Un)Marshal for internal objects: BaseAccount, Balance & Supply * PubKey in BaseAccount has three seperate entries for publick keys to avoid MarshalInterface. * custom json marshaler for BaseAccount to show a single pub key for json compatibility * feat: integrate ostracon (#317) * fix: treat addresses as strings * fix: compile errors, test failures * fix: works-1 * feat: integrate ostracon * fix: bump up ostracon * fix: lint error * fix: bump up ostracon * fix: self review * fix: modify changelog * fix: disable arm building * fix: bls build failure on arm * fix: bls build failure on arm * fix: bls build failure on arm * docs: modify changelog * fix: apply comment Co-authored-by: Woosang Son <woosang.son@linecorp.com>
whylee259
reviewed
Sep 13, 2021
| @@ -50,7 +50,7 @@ func (b Balance) Validate() error { | |||
| } | |||
|
|
|||
| // sort the coins post validation | |||
| b.Coins = b.Coins.Sort() | |||
| b.Coins.Sort() | |||
There was a problem hiding this comment.
Minor. This line has no effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrated ostracon.
Tendermintname toOstracon(but not all). I'll make new PR removingTendermintname from entire lfb.disabled arm, arm64 building from github action becauseI fixed it.blslibrary failed in building. I leftTODOcomment. We can fix afterblsmodule would be deleted.Main changed
Most of the files changed are for the ostracon name change.
Important changes are summarized below.
PrivKeyType
client/flags/flags.go
server/start.go
testutil/network/util.go
x/genutil/client/cli/collect.go
x/genutil/client/cli/init.go
x/genutil/client/cli/init_test.go
x/genutil/utils.go
VRFProof interface
crypto/ledger/ledger_secp256k1.go
x/ibc/testing/mock/privval.go
lint error
x/bank/simulation/params.go
x/bank/types/balance.go
x/ibc/applications/transfer/simulation/params.go
x/wasm/types/types_test.go
VotingPower (abci interface changed)
x/distribution/abci.go
x/distribution/keeper/allocation.go
x/distribution/keeper/allocation_test.go
x/simulation/mock_ostracon.go
x/slashing/abci_test.go
VoterSet concept
x/ibc/core/02-client/client/utils/utils.go
x/ibc/core/02-client/keeper/client_test.go
x/ibc/core/02-client/keeper/keeper_test.go
x/ibc/core/02-client/types/genesis_test.go
x/ibc/core/02-client/types/msgs_test.go
x/ibc/core/genesis_test.go
x/ibc/testing/chain.go
x/ibc/testing/chain_test.go
fix arm build failure
.github/workflows/test.yml
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes